Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PhpStan suggestions #378

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
+78 −30
Open

Fix PhpStan suggestions #378

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
57d7ec8
opened 2.7-dev
dg Oct 9, 2017
250c622
bar: replaced attribute 'rel' with 'data-tracy-action' for closing & …
dg Feb 18, 2019
e3996eb
Bluescreen: footer is always on bottom
dg Mar 3, 2019
ee22c3c
BlueScreen: removed source from footer
dg Mar 9, 2019
1d8b780
Logger: added priority to exception file name
dg Jul 15, 2019
fdaefa2
TracyExtension: added getConfigSchema()
dg Mar 11, 2019
6060d6c
tested against PHP 7.4
dg Aug 6, 2019
be818cc
Fix PhpStan suggestions
janbarasek Aug 10, 2019
dc60c08
Helpers: Revert write to undefined propert tracyAction
janbarasek Aug 10, 2019
6292e07
Bridge: CodeStyle
janbarasek Aug 10, 2019
ae2c34f
Composer: Added new dev dependencies
janbarasek Aug 11, 2019
85c9611
Fix by JanTvrdik suggestions
janbarasek Aug 11, 2019
3e52f92
Bridge: Use dev dependency and remove assert
janbarasek Aug 11, 2019
75fc178
bar.css: alt colors using transparency
dg Apr 1, 2020
5129995
BlueScreen: refactoring, added formatMessage()
dg Apr 2, 2020
8ba795c
BlueScreen::formatMessage() clickable methods & files
dg Apr 2, 2020
982e85e
BlueScreen: do not show Enviroment on 'Allowed memory size of *** byt…
dg Apr 3, 2020
d66385c
readme: info about nginx
dg Apr 6, 2020
b3218f8
Merge branch 'master' into phpstan-fix
janbarasek Apr 7, 2020
bf35591
Composer.json: Fix duplicated conflict section
janbarasek Apr 7, 2020
0843462
Helpers: Revert
janbarasek Apr 7, 2020
1f4e321
Bridge: Revert
janbarasek Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bluescreen: footer is always on bottom
@dg
dg committed Aug 5, 2019
commit e3996eb2136f808e6777d6aafa928c3e08ce9601
20 changes: 17 additions & 3 deletions src/Tracy/BlueScreen/assets/bluescreen.css
View file
Original file line number Diff line number Diff line change
@@ -36,6 +36,20 @@
padding: 3px;
}

.tracy-bs-main {
display: flex;
flex-direction: column;
min-height: 100vh;
}

.tracy-bs-main.tracy-collapsed {
display: none;
}

#tracy-bs div.panel:last-of-type {
flex: 1;
}

#tracy-bs-error {
background: #CD1818;
color: white;
@@ -153,7 +167,7 @@
list-style: none;
}

#tracy-bs-logo a {
#tracy-bs .footer-logo a {
position: absolute;
bottom: 0;
right: 0;
@@ -165,8 +179,8 @@
margin: 0;
}

#tracy-bs-logo a:hover,
#tracy-bs-logo a:focus {
#tracy-bs .footer-logo a:hover,
#tracy-bs .footer-logo a:focus {
opacity: 1;
transition: opacity 0.1s;
}
20 changes: 10 additions & 10 deletions src/Tracy/BlueScreen/assets/content.phtml
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ $code = $exception->getCode() ? ' #' . $exception->getCode() : '';
?>
<div id="tracy-bs" itemscope>
<a id="tracy-bs-toggle" href="#" class="tracy-toggle"></a>
<div>
<div class="tracy-bs-main">
<div id="tracy-bs-error" class="panel">
<?php if ($exception->getMessage()): ?><p><?= Helpers::escapeHtml($title . $code) ?></p><?php endif ?>

@@ -357,15 +357,15 @@ $code = $exception->getCode() ? ' #' . $exception->getCode() : '';
</div></div>
<?php endforeach ?>


<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">Please support Tracy via a donation 💙️</a></b></li>
<li>Report generated at <?= @date('Y/m/d H:i:s') // @ timezone may not be set ?></li>
<li><?php if ($sourceIsUrl): ?><a href="<?= Helpers::escapeHtml($source) ?>"><?php endif ?><?= Helpers::escapeHtml($source) ?><?php if ($sourceIsUrl): ?></a><?php endif ?></li>
<?php foreach ($info as $item): ?><li><?= Helpers::escapeHtml($item) ?></li><?php endforeach ?>
</ul>

<div id="tracy-bs-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
<footer>
<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">Please support Tracy via a donation 💙️</a></b></li>
<li>Report generated at <?= @date('Y/m/d H:i:s') // @ timezone may not be set ?></li>
<li><?php if ($sourceIsUrl): ?><a href="<?= Helpers::escapeHtml($source) ?>"><?php endif ?><?= Helpers::escapeHtml($source) ?><?php if ($sourceIsUrl): ?></a><?php endif ?></li>
<?php foreach ($info as $item): ?><li><?= Helpers::escapeHtml($item) ?></li><?php endforeach ?>
</ul>
<div class="footer-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
</footer>
</div>
<meta itemprop=tracy-snapshot content=<?= Dumper::formatSnapshotAttribute($snapshot) ?>>
</div>
18 changes: 9 additions & 9 deletions tests/Tracy/expected/Debugger.E_ERROR.html.expect
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<body>
<div id="tracy-bs" itemscope>
<a id="tracy-bs-toggle" href="#" class="tracy-toggle"></a>
<div>
<div class="tracy-bs-main">
<div id="tracy-bs-error" class="panel">
<p>Error</p>

@@ -211,14 +211,14 @@




<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>

<div id="tracy-bs-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
<footer>
<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>
<div class="footer-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
</footer>
</div>
<meta itemprop=tracy-snapshot content=%a%>
</div>
18 changes: 9 additions & 9 deletions tests/Tracy/expected/Debugger.error-in-eval.expect
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<body>
<div id="tracy-bs" itemscope>
<a id="tracy-bs-toggle" href="#" class="tracy-toggle"></a>
<div>
<div class="tracy-bs-main">
<div id="tracy-bs-error" class="panel">
<p>User Error</p>

@@ -182,14 +182,14 @@




<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>

<div id="tracy-bs-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
<footer>
<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>
<div class="footer-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
</footer>
</div>
<meta itemprop=tracy-snapshot content=%a%>
</div>
18 changes: 9 additions & 9 deletions tests/Tracy/expected/Debugger.exception.html.expect
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<body>
<div id="tracy-bs" itemscope>
<a id="tracy-bs-toggle" href="#" class="tracy-toggle"></a>
<div>
<div class="tracy-bs-main">
<div id="tracy-bs-error" class="panel">
<p>Exception #123</p>

@@ -178,14 +178,14 @@




<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>

<div id="tracy-bs-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
<footer>
<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>
<div class="footer-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
</footer>
</div>
<meta itemprop=tracy-snapshot content=%a%>
</div>
18 changes: 9 additions & 9 deletions tests/Tracy/expected/Debugger.strict.html.expect
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<body>
<div id="tracy-bs" itemscope>
<a id="tracy-bs-toggle" href="#" class="tracy-toggle"></a>
<div>
<div class="tracy-bs-main">
<div id="tracy-bs-error" class="panel">
<p>Notice</p>

@@ -185,14 +185,14 @@




<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>

<div id="tracy-bs-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
<footer>
<ul>
<li><b><a href="https://nette.org/make-donation?to=tracy" target="_blank" rel="noreferrer noopener">%a%️</a></b></li>
<li>Report generated at %a%</li>
<li>CLI%a?%</li>
<li>PHP %a%</li> </ul>
<div class="footer-logo"><a href="https://tracy.nette.org" rel="noreferrer"></a></div>
</footer>
</div>
<meta itemprop=tracy-snapshot content=%a%>
</div>