[integration-k8s-kind#325] Use existing VPP instance if given #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <[email protected]>
Bolodya1997
force-pushed
the
integration-k8s-kind#325/vpp-api-socket
branch
2 times, most recently
from
0a265d2
to
12e2e75
Compare
Signed-off-by: Vladimir Popov <[email protected]>
Bolodya1997
force-pushed
the
integration-k8s-kind#325/vpp-api-socket
branch
from
12e2e75
to
d9c1d98
Compare
6 tasks
denis-tingaikin
approved these changes
Aug 27, 2021
|
@edwarnicke this looks good to me. Do you have any comments on these changes? |
|
@Bolodya1997 I don't intrinsically object to this... but I'm super curious the use case :) |
|
Not needed because we don't want to share VPP instance with NSC application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
VPPApiSocketconfig parameter to use existing VPP instance instead of starting a new one.Issue link
networkservicemesh/integration-k8s-kind#325
How Has This Been Tested?
Types of changes