Skip to content

Fix cisco_nxos_show_hsrp_all for initial state #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2025

Conversation

betrunkenaffe
Copy link
Contributor

Updated HSRP_ROUTER_STATE regex to handle following state string (existing fails on the space):

Initial(Interface Down)

Alternative regex was (\S+\s?\S*) if this is too specific

Updated HSRP_ROUTER_STATE regex to handle following state string (existing fails on the space):

Initial(Interface Down)
@mjbear
Copy link
Collaborator

mjbear commented Apr 26, 2025

Hi @betrunkenaffe

We also need test data added to this PR. Do not replace the existing test data, add a new file.

As long as you put the raw data in the correct spot, you can use helper scripts to generate the structured data (yaml).

The test data is necessary so that we can make sure the template is backwards compatible in the future when more changes are needed.

🎯 Please respond back if there are any questions. Thank you!

@mjbear mjbear added the status: action required This issue requires additional information to be actionable label Apr 26, 2025
@mjbear
Copy link
Collaborator

mjbear commented May 1, 2025

@betrunkenaffe
Please include raw cli test data and generate structured data as part of this PR.

See my previous comment for some guidance. Thank you!

@mjbear
Copy link
Collaborator

mjbear commented May 4, 2025

@betrunkenaffe Please include raw cli test data and generate structured data as part of this PR.

See my previous comment for some guidance. Thank you!

@betrunkenaffe
I have retrieved some nxos HSRP raw output that has the Initial(Interface Down) HSRP state. This makes this PR whole, otherwise in time it could have been closed because of the missing required test data.

You're welcome to add more test data should you have anything different. ☺️

@mjbear mjbear removed the status: action required This issue requires additional information to be actionable label May 4, 2025
@mjbear mjbear changed the title Update cisco_nxos_show_hsrp_all.textfsm Fix cisco_nxos_show_hsrp_all for initial state May 4, 2025
@mjbear mjbear merged commit 1fc6664 into networktocode:master May 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants