-
Notifications
You must be signed in to change notification settings - Fork 767
Add uptime to Arista show version #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uptime to Arista show version #2113
Conversation
@Mikeg2881 Then generate the structured output (yaml) using the helper scripts. Look over that generated output for accuracy. And finally please commit those two files to your branch and push them to GitHub. Thank you! 🎉 Note: Since this template also did not have an error directive, I'll probably take the time to fix that up before we merge this PR. |
See attached |
Please add the raw cli text in the correct directory. For example the new raw cli file could be named: With the raw cli text in place, then generate structured data with the helper scripts. |
Sorry I don't follow. As in put it in my branch and commit/push it? |
Correct. Add a new raw file in the proper tests dir with your output. Then use the helper scripts to generate the structured data (yaml). Commit both the raw and yaml files to your arista branch and push those changes to GitHub (when doing so they'll show up on this PR that uses your arista branch). I hope this helps. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
changes based off this issue url