Skip to content

Add uptime to Arista show version #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 1, 2025

Conversation

Mikeg2881
Copy link
Contributor

@Mikeg2881 Mikeg2881 commented Apr 27, 2025

changes based off this issue url

@mjbear mjbear linked an issue Apr 28, 2025 that may be closed by this pull request
@mjbear mjbear changed the title Changed Arista Show Version Add uptime to Arista show version Apr 28, 2025
@mjbear mjbear added changes_requested Waiting on user to address feedback WIP Work in Progress labels Apr 28, 2025
@mjbear
Copy link
Collaborator

mjbear commented Apr 28, 2025

@Mikeg2881
Please add your example test data from #2110 (comment) in a new raw file. Example name for that filetests/arista_eos/show_version/arista_eos_show_version2.raw

Then generate the structured output (yaml) using the helper scripts. Look over that generated output for accuracy.

And finally please commit those two files to your branch and push them to GitHub.

Thank you! 🎉

Note: Since this template also did not have an error directive, I'll probably take the time to fix that up before we merge this PR.

@mjbear mjbear self-assigned this Apr 28, 2025
@Mikeg2881
Copy link
Contributor Author

See attached
arista_eos_show_version.zip

@mjbear
Copy link
Collaborator

mjbear commented Apr 28, 2025

See attached arista_eos_show_version.zip

Please add the raw cli text in the correct directory. For example the new raw cli file could be named:
tests/arista_eos/show_version/arista_eos_show_version2.raw

With the raw cli text in place, then generate structured data with the helper scripts.

@Mikeg2881
Copy link
Contributor Author

Sorry I don't follow. As in put it in my branch and commit/push it?

@mjbear
Copy link
Collaborator

mjbear commented Apr 28, 2025

Sorry I don't follow. As in put it in my branch and commit/push it?

Correct.

Add a new raw file in the proper tests dir with your output.

Then use the helper scripts to generate the structured data (yaml).

Commit both the raw and yaml files to your arista branch and push those changes to GitHub (when doing so they'll show up on this PR that uses your arista branch).

I hope this helps. 🙂

@mjbear mjbear removed changes_requested Waiting on user to address feedback WIP Work in Progress labels May 1, 2025
Copy link
Collaborator

@mjbear mjbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mjbear mjbear merged commit dfba389 into networktocode:master May 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arista_eos_show_version (Updates)
2 participants