Skip to content

Add IOS inline power support for 68xx #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 9, 2025
Merged

Add IOS inline power support for 68xx #2115

merged 8 commits into from
May 9, 2025

Conversation

mjbear
Copy link
Collaborator

@mjbear mjbear commented Apr 29, 2025

resolves #2114

  • Add support for 6807-XL that has no power card
  • Add support for 6880-X headers and output when no power is delivered (no PD, powered devices exist)

@mjbear mjbear self-assigned this Apr 29, 2025
@mjbear
Copy link
Collaborator Author

mjbear commented May 1, 2025

We don't have 6880-X output that supports PoE so this PR is as ready as we can make it presently.

@mjbear mjbear marked this pull request as ready for review May 1, 2025 23:32
@Mikeg2881
Copy link
Contributor

It looks like somewhere in the mix it was forgott to fix the issue with "faulty"
Value OPERATIONAL_STATUS (on|off|faulty)

But i recall you saying there might be a better way to do it, in case there is another work besides faulty?

@Mikeg2881
Copy link
Contributor

Also i do not recall if we accounted for Device/Class and Max having no data as that created an error.

------   ---------   --------   ---------
3           390.0        0.0       390.0
Interface Admin  Oper       Power   Device              Class Max
                            (Watts)                            
--------- ------ ---------- ------- ------------------- ----- ----
Gi3/0/7   auto   off        0.0    
Gi3/0/8   auto   off        0.0     n/a                 n/a   30.0

@mjbear
Copy link
Collaborator Author

mjbear commented May 6, 2025

It looks like somewhere in the mix it was forgott to fix the issue with "faulty" Value OPERATIONAL_STATUS (on|off|faulty)

But i recall you saying there might be a better way to do it, in case there is another work besides faulty?

It doesn't appear we have test data for this condition.
Might you have test data that can be included in this PR?

@mjbear
Copy link
Collaborator Author

mjbear commented May 6, 2025

Also i do not recall if we accounted for Device/Class and Max having no data as that created an error.

As best I recall this isn't something we discussed earlier.

All good though, you caught it and I was able to add lines in to cover it.

@Mikeg2881
Copy link
Contributor

Mikeg2881 commented May 6, 2025 •
edited
Loading 

Module   Available     Used     Remaining
          (Watts)     (Watts)    (Watts) 
------   ---------   --------   ---------
1           390.0      209.6       180.4
Interface Admin  Oper       Power   Device              Class Max
                            (Watts)                            
--------- ------ ---------- ------- ------------------- ----- ----
Gi1/0/1   auto   on         3.8     Poly Poly Edge B20  1     30.0 
Gi1/0/2   auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/3   auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/4   auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/5   auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/6   auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/7   auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/8   auto   on         3.8     Poly Poly Edge B20  1     30.0 
Gi1/0/9   auto   on         15.4    Ieee PD             4     30.0 
Gi1/0/10  auto   on         3.8     Poly Poly Edge B20  1     30.0 
Gi1/0/11  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/12  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/13  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/14  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/15  auto   on         15.4    Ieee PD             4     30.0 
Gi1/0/16  auto   on         3.8     Poly Poly Edge B20  1     30.0 
Gi1/0/17  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/18  auto   on         15.4    Ieee PD             4     30.0 
Gi1/0/19  auto   on         3.8     Poly Poly Edge B20  1     30.0 
Gi1/0/20  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/21  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/22  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/23  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/24  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/25  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/26  auto   off        0.0     n/a                 n/a   30.0 
Gi1/0/27  auto   faulty     0.0     n/a                 n/a   30.0

@mjbear
Copy link
Collaborator Author

mjbear commented May 6, 2025

Gi1/0/27 auto faulty 0.0 n/a n/a 30.0

A code fence (<> button) is needed to preserve the whitespace.

@Mikeg2881
Would you update your previous comment with the raw cli output in a code fence?

I'll do my best to get the output close in the meantime.

Thank you!

@mjbear
Copy link
Collaborator Author

mjbear commented May 6, 2025 •
edited
Loading

Gi1/0/27 auto faulty 0.0 n/a n/a 30.0

A code fence (<> button) is needed to preserve the whitespace.

@Mikeg2881 Would you update your previous comment with the raw cli output in a code fence?

I'll do my best to get the output close in the meantime.

Thank you!

PR #2101 has a fix for the faulty operational state, but that PR hasn't been merged yet.

In that PR, instead of adding the literal word "faulty", I swapped the on|off regex to a \S+ to match words.

I'll have to remember this because this will cause a minor merge conflict. 🙂

@mjbear mjbear force-pushed the ios_sh_pwr_inline_issue2114 branch from 45237f2 to 80d3144 Compare May 9, 2025 00:15
@mjbear mjbear merged commit 3e53331 into networktocode:master May 9, 2025
10 checks passed
@mjbear mjbear deleted the ios_sh_pwr_inline_issue2114 branch May 9, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees

@mjbear mjbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cisco_ios_show_power_inline
3 participants
@mjbear @Mikeg2881 @jmcgill298