Fix encapsulation column in Arista sh int status #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbyers
reviewed
Apr 30, 2025
ntc_templates/templates/arista_eos_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
|
Looks good to me. |
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
jmcgill298
reviewed
May 6, 2025
tests/arista_eos/show_interfaces_status/arista_eos_show_interfaces_status_encap.raw
Outdated
Show resolved
Hide resolved
…aces_status_encap.raw
jmcgill298
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2117
\S+regex should there ever be text in the Encapsulation columnTYPEcapture group regex so trailing whitespace was not capturedNote:
If there is ever encapsulation data, but not flags, this could cause a parsing issue where data could end up in the wrong capture group for those two. We don't have raw test data that includes data in the Flags column or Encapsulation. Thank you for understanding!