Update cisco_ios_show_interface_link.textfsm #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malvin3197
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa and
mjbear
as code owners
|
@Malvin3197 We also need test data added to this PR. Do not replace the existing test data, but it is ok to either add to an existing file OR in some cases it is better to add a new file. As long as you put the raw data in the correct spot, you can use helper scripts to generate the structured data (yaml). The test data is necessary so that we can make sure the template is backwards compatible in the future when more changes are needed. 🎯 Please respond back if there are any questions. Thank you! |
mjbear
added
status: action required
Make "d" character optional. Example: Port Name Down Time Up Time Te1/0/1 1y1w Te1/0/2 1y1w Te1/0/3 1y1w added tests update to allow #y#w format updated uptime also
Malvin3197
force-pushed
the
update_cisco_ios_show_interface_link_day_optional
branch
from
cb01025 to
d2ceac9
Compare
|
Hi @mjbear , Test Data added. Also ran tests locally and passed. Thank you so much for the help! |
Little sense in parsing a bunch of nearly duplicate rows
mjbear
reviewed
May 10, 2025
The square brackets are not needed for the optional pattern since there is only a single optional character within them.
mjbear
removed
the
status: action required
|
I walked back on my thought about a separate PR. Since the couple of refactors are simple they can land in this PR.
|
mjbear
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: "State Error raised. Rule Line: 32. Input Line: Te1/0/1 1y1w"
Fix:
Make "d" character optional.
Example:
Port Name Down Time Up Time
Te1/0/1 1y1w
Te1/0/2 1y1w
Te1/0/3 1y1w