Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix the docstring in eda_process for SCR_RiseTime #1033

Merged

Conversation

DerAndereJohannes
Copy link
Contributor

There was a human error in converting the docstrings in eda_process.py during the codebook conversion. SCR_RiseTime had the same description as SCR_Amplitude after the change. This PR reverts the description to what it was before.

This PR closes #1031 .

Description

Fix a docstring mistake while migrating to the new standard.

Proposed Changes

Revert docstring value to what it was before.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@DominiqueMakowski
Copy link
Member

Missed that, sorry!

@DominiqueMakowski DominiqueMakowski changed the title Fix the docstring in eda_process for SCR_RiseTime [docs] Fix the docstring in eda_process for SCR_RiseTime Nov 25, 2024
@DominiqueMakowski DominiqueMakowski merged commit 45a5e5f into neuropsychology:dev Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants