Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] build docs warning #968

Merged
merged 9 commits into from
Mar 3, 2024

Conversation

danibene
Copy link
Collaborator

@danibene danibene commented Mar 2, 2024

Description

This PR aims to fix the failed documentation build check: https://github.com/neuropsychology/NeuroKit/actions/runs/8094952153/job/22120703414

Proposed Changes

I changed the emg_activation() function to index a DataFrame with .loc

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 54.59%. Comparing base (56aba7f) to head (6f0f0a2).
Report is 3 commits behind head on dev.

Files Patch % Lines
neurokit2/complexity/utils_complexity_symbolize.py 0.00% 9 Missing ⚠️
neurokit2/emg/emg_activation.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #968      +/-   ##
==========================================
- Coverage   54.59%   54.59%   -0.01%     
==========================================
  Files         304      304              
  Lines       14325    14326       +1     
==========================================
  Hits         7821     7821              
- Misses       6504     6505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 2, 2024
@DominiqueMakowski
Copy link
Member

DominiqueMakowski commented Mar 3, 2024

merge whenever you want (I've been away from NK for some time but will return soon) - we should probably aim at releasing the dev in a close future :)

@danibene danibene merged commit 0ea8a2b into neuropsychology:dev Mar 3, 2024
8 checks passed
@danibene danibene deleted the fix/build_docs_warning branch March 3, 2024 14:31
@danibene
Copy link
Collaborator Author

danibene commented Mar 3, 2024

merge whenever you want (I've been away from NK for some time but will return soon) - we should probably aim at releasing the dev in a close future :)

Sounds good! Hope you're well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants