Skip to content

[FIX] supress cluttering warning #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Jun 13, 2025

Closes # more feedback from for unhelpful warnings

Changes proposed in this pull request:

  • suppress the warning from invalid value encountered

Summary by Sourcery

Bug Fixes:

  • Suppress invalid value encountered warnings in mm2vox affine conversion

Copy link
Contributor

sourcery-ai bot commented Jun 13, 2025

Reviewer's Guide

Wrapped the affine transformation in mm2vox within a NumPy error-state context to ignore non-critical 'invalid value encountered' warnings.

Sequence Diagram: Warning Suppression in mm2vox

sequenceDiagram
    participant Caller
    participant mm2vox as "mm2vox()"
    participant ErrState as "numpy.errstate(invalid='ignore')"
    participant ApplyAffine as "nib.affines.apply_affine()"

    Caller->>mm2vox: Invoke with xyz, affine
    activate mm2vox
    mm2vox->>ErrState: Enter context
    activate ErrState
    mm2vox->>ApplyAffine: Call (potential 'invalid value' warning internally)
    ApplyAffine-->>mm2vox: Return result (warning suppressed by ErrState)
    deactivate ErrState
    mm2vox-->>Caller: Return ijk (no warning propagated to Caller)
    deactivate mm2vox
Loading

File-Level Changes

Change Details Files
Suppress 'invalid value encountered' warnings during mm2vox conversion
  • Enclose nib.affines.apply_affine call in np.errstate(invalid='ignore')
  • Move ijk assignment inside the context manager block
nimare/utils.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jdkent jdkent merged commit 7e419f5 into neurostuff:main Jun 13, 2025
18 of 19 checks passed
@jdkent jdkent added the bug Issues noting problems and PRs fixing those problems. label Jun 13, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jdkent - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.44%. Comparing base (db35391) to head (6227664).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   88.45%   88.44%   -0.02%     
==========================================
  Files          48       48              
  Lines        6524     6532       +8     
==========================================
+ Hits         5771     5777       +6     
- Misses        753      755       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant