PERF: implement multi-threading parallelism in inifix-validate CLI
#234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
inifix-validate CLI
neutrinoceros
force-pushed
the
validate/perf/multithreading
branch
3 times, most recently
from
a4488c5 to
893ff1e
Compare
neutrinoceros
force-pushed
the
validate/perf/multithreading
branch
3 times, most recently
from
c17b57b to
1ca49e0
Compare
neutrinoceros
force-pushed
the
validate/perf/multithreading
branch
from
1ca49e0 to
af6d80f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative follow up to #229
Although I'm glad that my refactors for
inifix-formatmade this super easy to implement, this one really doesn't gain anything in any scenario I tested (and actually seems slower everywhere). I suspect that the overhead from the added complexity overweights any modest gain I could hope for here, but I'm going to keep it around for now, and maybe revisit with Python 3.14 pre-releases.