Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support set monitor info and scale #172

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

okhowang
Copy link
Contributor

relate neutrinolabs/xrdp#1692

use client info set parameter for xorg.

many window managers have different scale setting method.
see https://wiki.archlinux.org/index.php/HiDPI .
It seems that cannot adapt for all wm.

and there is no other multi monitor dpi solution except https://askubuntu.com/a/555812
but it will break layout of monitors. because it will change resolution of monitors.

so I don't process scale in this PR.

@okhowang
Copy link
Contributor Author

I found use xf86SetApi can set global dpi for X system.
but It didn't work if I call it in rdpRRSetRdpOutputs.
can we load client_info earlier for compute dpi in rdpPreInit

module/rdpRandR.c Outdated Show resolved Hide resolved
@metalefty metalefty added this to the v0.2.16 milestone Dec 21, 2020
@metalefty metalefty modified the milestones: v0.2.16, v0.2.17 Apr 24, 2021
Nexarian added a commit to Nexarian/xorgxrdp that referenced this pull request Jul 2, 2022
This is a shameless copy of
neutrinolabs#172 for my own prototyping
and editing purposes.

We need to figure out how to get xf86SetDpi working.
@Nexarian
Copy link
Contributor

Nexarian commented Jul 2, 2022

We already call xf86SetDpi here:

xf86SetDpi(pScrn, 0, 0);

As to the right place to call it to make it work for client info, I'm not yet sure. We should play with it. I've also shameless copied your code here: https://github.com/Nexarian/xorgxrdp/pull/new/dpi_resizing_prototype so I can play with it. It is rebased off the latest devel branch.

@jsorg71 Do you know where we should put xf86SetDpi for screen resizing purposes? We should also pay attention to this for LRandR use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants