resize queue: drop unactioned client requests #3636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a source tag for all the resize_queue items, so we can make some decisions about queue optimisations.
The wait_obj calls (mostly) ignore objects with a value of zero. This is codified, so that user code can explicitly make use of this.
Processing of the resize queue is delayed until we've connected to a session, as the login screen is currently unable to cope with these requests.
If we're adding a new client request to the queue, and the item immediately before it is also a client request which is not yet actioned, we can remove the previous item, as it has been superceded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3618
There are two main parts to this:-
Testing was performed with an XFCE session running
glxgears. The client was xfreerdp which is capable of sending a stream of closely-spaced DISPLAYCONTROL_MONITOR_LAYOUT_PDUs. Queued requests were dropped, but the final size was always correct.