configure.ac: enabled -Wextra compiler warning
#3660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
```
fontutils/fv1.c:36:1: error: ‘static’ is not at beginning of declaration [-Werror=old-style-declaration]
36 | const static char FV1_SIGNATURE[] = {'F', 'N', 'T', '1'};
| ^~~~~
```
```
/home/user/CLionProjects/xrdp/common/list.c: In function ‘list_create_sized’:
/home/user/CLionProjects/xrdp/common/list.c:50:41: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
50 | self = (struct list *)calloc(sizeof(struct list), 1);
| ^~~~~~
/home/user/CLionProjects/xrdp/common/list.c:50:41: note: earlier argument should specify number of elements, later size of each element
```
xrdp uses C zero initializers quite a bit. If '-Wextra' is specified, these generate compiler warnings. This command adds two macros ALLOW_ZERO_INITIALIZER_BEGIN and ALLOW_ZERO_INITIALIZER_BEGIN which allow the compiler warnings to be silenced with zero initializers.
Fixes a gcc compiler warning regarding a potentially unportable use of 'defined()' in a macro
|
@firewave - I've taken the liberty of adding a couple of commits to your PR.
|
If you are fine with adding annotations so am I. I would have just disabled the warnings as to keep the code clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.