set plot type for calibration metrics to be errorbar_y #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #580 +/- ##
==========================================
+ Coverage 95.93% 96.31% +0.37%
==========================================
Files 71 71
Lines 5660 5664 +4
==========================================
+ Hits 5430 5455 +25
+ Misses 230 209 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
small change to set the plot type of the workspaces generated during difcal
Explanation of work
The metric workspaces generated to assess difcal quality are derived from fits of a Gaussian peak shape to Bragg peaks. As such they consist of a fitted value and estimated uncertainty. This information is best displayed as a plot with markers and error bars versus a line plot with no markers at all. This change sets the plotting property of the output workspaces to reflect this.
To test
Dev testing
Run difcal in workbench, plot calibration metric workspaces and check they consist of markers with error bars
CIS testing
# replace with your test script belowLink to EWM item
EWM#<ticket_number>
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.