-
Notifications
You must be signed in to change notification settings - Fork 0
Migrate from CONDA to pixi #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a few comments/questions but nothing I'm gonna hold you guys up on.
I'd recommend taking a look at the pixi migration guide i wrote if you haven't, just to get a sense of what these changes are looking like across the LSS packages and a few others.
but if it works for you and you're happy with it, feel free to disregard!
also sorry github decided to ignore what lines i highlighted when leaving my comments...
| exclude: "tests/cis_tests/.*" | ||
|
|
||
| - repo: https://github.com/codespell-project/codespell | ||
| rev: v2.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to add a hook to check that the lockfile is up to date, I've found it really convenient since I tend to forget to run "pixi lock" before committing and then CI fails and I have to make another one file commit...
|
hmmm you shouldn't need a conda recipe, what was it complaining about? |
Short description of the changes:
Migrate SNAPWrap build system from Conda to PIXI for improved environment management, reproducibility, and developer experience.
Long description of the changes:
This migration modernizes SNAPWrap's build and development workflow by replacing Conda with PIXI as the primary environment manager. Key improvements include:
pixi installcommand sets up complete development environment with all dependenciesThe migration includes proper integration of specialized neutron analysis dependencies (mantid, snapred) from ORNL channels, ensuring the scientific workflow remains fully functional.
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
Environment Setup:
Verify Dependencies:
pixi run python -c "import mantid; import snapred; import snapwrap; print('All imports successful')"Run Tests:
pixi run testBuild Verification:
Conda Build Test (optional, takes 5+ minutes):
References