Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase task_class input validation and log messages #191

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Oct 10, 2024

Description of the changes

Workflow Manager postprocessing tasks can optionally be defined by giving a "task class" in the database table report_task. This change improves the input validation and log messages for the task class entry.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:
Story 6374: [WebMon] Improve workflow manager "task_class" error

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (b6b0d49) to head (6d6362b).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #191      +/-   ##
==========================================
+ Coverage   77.52%   77.77%   +0.24%     
==========================================
  Files          54       54              
  Lines        4704     4720      +16     
==========================================
+ Hits         3647     3671      +24     
+ Misses       1057     1049       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari merged commit 100be00 into next Oct 15, 2024
4 checks passed
@backmari backmari deleted the task_class_error branch October 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants