Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant conda package build (replaced by python-build) #193

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Nov 5, 2024

Description of the changes

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (4994a45) to head (cf019ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #193   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files          54       54           
  Lines        4720     4720           
=======================================
  Hits         3671     3671           
  Misses       1049     1049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield merged commit c405846 into next Nov 5, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the conda_python_build branch November 5, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants