Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context of values when exceptions are thrown #224

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

peterfpeterson
Copy link
Member

SystemExit was not caught. This is now caught and logged.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.73%. Comparing base (9f73e13) to head (00ac8fa).

Files with missing lines Patch % Lines
src/webmon_app/reporting/report/view_util.py 17.64% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #224      +/-   ##
==========================================
- Coverage   77.89%   77.73%   -0.16%     
==========================================
  Files          54       54              
  Lines        4741     4752      +11     
==========================================
+ Hits         3693     3694       +1     
- Misses       1048     1058      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching the SystemExit and adding a message with the instrument will help with troubleshooting errors we have seen. Looks good to me.

@backmari backmari merged commit 08c4a8f into next Mar 4, 2025
4 checks passed
@backmari backmari deleted the more_error_logging branch March 4, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants