Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string formatting issue and log return of fetchone() #227

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Mar 4, 2025

There was an extra argument in a formatting string which hid the log we were actually looking for. This fixes that and logs the return of fetchone() for more information.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@peterfpeterson peterfpeterson marked this pull request as ready for review March 4, 2025 15:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (08c4a8f) to head (ea1d151).

Files with missing lines Patch % Lines
src/webmon_app/reporting/report/view_util.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #227      +/-   ##
==========================================
- Coverage   77.73%   77.68%   -0.05%     
==========================================
  Files          54       54              
  Lines        4752     4760       +8     
==========================================
+ Hits         3694     3698       +4     
- Misses       1058     1062       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to show the output of fetchone.

@backmari backmari merged commit 968238f into next Mar 4, 2025
4 checks passed
@backmari backmari deleted the logging_args branch March 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants