Skip to content

Update and cleanup thirdparty libraries #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Update and cleanup thirdparty libraries #237

merged 3 commits into from
Mar 19, 2025

Conversation

rosswhitfield
Copy link
Member

Description of the changes

This is a general cleanup of the third-party javascript libraries we include as I prepare to replace dynatables with datatables.

  • Removed unused javascript
  • Removed unused templates
  • Update to newest versions of jquery and jquery-ui

I didn't update the plotly or d3 libraries as I will let that be done as part of 9549: Update to python plotly version 6

I tried to verify that all the javascript was running correctly everywhere. The updates didn't appear to break anything.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (27aee2d) to head (43f4952).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #237   +/-   ##
=======================================
  Coverage   77.92%   77.92%           
=======================================
  Files          59       59           
  Lines        4683     4683           
=======================================
  Hits         3649     3649           
  Misses       1034     1034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rosswhitfield rosswhitfield requested a review from backmari March 19, 2025 05:14
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to clean up unused thirdparty libraries and resources and upgrade to the latest jquery version.
I tested locally and the app behaves as expected and there were no logged errors.

@rosswhitfield rosswhitfield merged commit dcde136 into next Mar 19, 2025
4 checks passed
@rosswhitfield rosswhitfield deleted the update_js branch March 19, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants