Skip to content

Replace dynatables with datatables #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 27, 2025
Merged

Replace dynatables with datatables #238

merged 15 commits into from
Mar 27, 2025

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Mar 24, 2025

Description of the changes

The following pages have been changed (you can change to any instrument or IPTS)

I have implemented columns searching where it made sense, so you can filter on multiple columns together.

This also fixes issues with viewing large IPTS's, e.g. http://localhost/report/hb2c/experiment/IPTS-7776/ as reported in 10256: [WebMon] IPTS summary page error for large number of runs

This will also allow us to increase the LATEST_RUNS_TIME_RANGE_HOURS back to 12 hours or even more.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 99.40120% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.19%. Comparing base (dcde136) to head (8217af0).

Files with missing lines Patch % Lines
src/webmon_app/reporting/reduction/views.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #238      +/-   ##
==========================================
+ Coverage   77.92%   79.19%   +1.27%     
==========================================
  Files          59       59              
  Lines        4683     4624      -59     
==========================================
+ Hits         3649     3662      +13     
+ Misses       1034      962      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rosswhitfield rosswhitfield marked this pull request as ready for review March 26, 2025 03:32
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally that the tables and their new functionality work as expected. The code changes look good and include appropriate testing. This PR also reduces duplicated logic by combining the logic for getting data for the initial view and update of the view.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is so much easier to read and understand now. And it's great to not have duplicated logic for initial display and update.

@rosswhitfield rosswhitfield merged commit b714918 into next Mar 27, 2025
4 checks passed
@rosswhitfield rosswhitfield deleted the move_to_datatables branch March 27, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants