-
Notifications
You must be signed in to change notification settings - Fork 3
Replace dynatables with datatables #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…instruments in the INSTRUMENT_REDUCTION_SETUP settings have configrations pages and all those have specialize implemenations.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #238 +/- ##
==========================================
+ Coverage 77.92% 79.19% +1.27%
==========================================
Files 59 59
Lines 4683 4624 -59
==========================================
+ Hits 3649 3662 +13
+ Misses 1034 962 -72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d7b06ac
to
fde4a68
Compare
ba0667d
to
781f6f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested locally that the tables and their new functionality work as expected. The code changes look good and include appropriate testing. This PR also reduces duplicated logic by combining the logic for getting data for the initial view and update of the view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is so much easier to read and understand now. And it's great to not have duplicated logic for initial display and update.
Description of the changes
The following pages have been changed (you can change to any instrument or IPTS)
I have implemented columns searching where it made sense, so you can filter on multiple columns together.
This also fixes issues with viewing large IPTS's, e.g. http://localhost/report/hb2c/experiment/IPTS-7776/ as reported in 10256: [WebMon] IPTS summary page error for large number of runs
This will also allow us to increase the
LATEST_RUNS_TIME_RANGE_HOURS
back to 12 hours or even more.Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer