Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiphonon dependency upgrade #158

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Multiphonon dependency upgrade #158

merged 4 commits into from
Oct 17, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Oct 14, 2024

Short description of the changes:

The code includes changes related to upgrading the package dependencies, e.g. Mantid and avoid pinning (==) to specific versions.

Long description of the changes:

More specifically, it includes:

  • pyproject requirements updates
  • environment updates, including using the neutrons histogram dev.
  • github actions simplified with the recent tools available

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

Test with histogram and multiphonon tests in the new environment

References

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (36e97d0) to head (08917dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #158      +/-   ##
==========================================
+ Coverage   88.79%   89.03%   +0.23%     
==========================================
  Files          23       23              
  Lines        1392     1395       +3     
==========================================
+ Hits         1236     1242       +6     
+ Misses        156      153       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou changed the title Multiphonon dependency test Multiphonon dependency upgrade Oct 15, 2024
@KyleQianliMa
Copy link

Tested in both environment and all tests in both histogram and multiphonon passes

@mpatrou mpatrou merged commit fd555f9 into next Oct 17, 2024
4 checks passed
@mpatrou mpatrou deleted the multiphonon_dep_test branch October 17, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants