Skip to content

Commit

Permalink
switch mantid to mantidworkbench (#12)
Browse files Browse the repository at this point in the history
* switch mantid to mantidworkbench

Signed-off-by: Jose Borreguero <[email protected]>

* updated pull request template

Signed-off-by: Jose Borreguero <[email protected]>

* add release notes

Signed-off-by: Jose Borreguero <[email protected]>

---------

Signed-off-by: Jose Borreguero <[email protected]>
  • Loading branch information
jmborr authored Jul 22, 2024
1 parent 6fcf4b8 commit f24bf10
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 13 deletions.
23 changes: 14 additions & 9 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,26 @@
# Description of the changes


Check all that apply:
- [ ] added [release notes](https://github.com/neutrons/usansred/blob/next/docs/source/releases.rst) (if not, provide an explanation in the work description)
- [ ] updated documentation
- [ ] Source added/refactored
- [ ] Added unit tests
- [ ] Added integration tests
- [ ] Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

**References:**
- Links to IBM EWM items:
- Links to related issues or pull requests:

# Manual test for the reviewer
<!-- Instructions for testing here. -->

# Check list for the reviewer
- [ ] [release notes](https://github.com/neutrons/usansred/blob/next/docs/source/releases.rst) updated, or an explanation is provided as to why release notes are unnecessary
- [ ] best software practices
+ [ ] clearly named variables (better to be verbose in variable names)
+ [ ] code comments explaining the intent of code blocks
- [ ] All the tests are passing
- [ ] The documentation is up to date
- [ ] code comments added when explaining intent
-
# Check list for the pull request
- [ ] source refactored/incremented
- [ ] tests for my changes
- [ ] updated the documentation accordingly

# References
<!-- Links to related issues or pull requests -->
<!-- Links to IBM EWM items if aaplicable -->
16 changes: 16 additions & 0 deletions docs/source/releases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,24 @@
Release Notes
=============

<Next Release>
--------------
(date of release)

**Of interest to the User**:

- PR #XYZ: one-liner description

**Of interest to the Developer:**

- PR #12: switch from mantid to mantidworkbench conda package

1.0.0
-----
2024-05-06

This is the first release of USANSRED.

- repository implements the `OpenSSF Best Practices Badge Program <https://www.bestpractices.dev/en/criteria/0>`_
- codecov reports for every accepted change, uploaded to `codecov usansred <https://app.codecov.io/gh/neutrons/usansred>`_
- generation of conda packages, uploaded to the `neutrons channel <https://anaconda.org/neutrons/usansred/files>`_
Expand Down
5 changes: 1 addition & 4 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,9 @@ channels:
dependencies:
- python=3.10
- versioningit
- mantid=6.9.1
- numpy
- scipy
- mantidworkbench=6.9.1
- pandas
- xlsxwriter
- matplotlib
- pip
- pip:
- git+https://github.com/peterfpeterson/[email protected]
Expand Down

0 comments on commit f24bf10

Please sign in to comment.