Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take average of intensity values with duplicate Q AND solve the issue… #13

Merged
merged 13 commits into from
Aug 15, 2024

Conversation

yrshang
Copy link
Collaborator

@yrshang yrshang commented Aug 8, 2024

… with bg interpolation when bg q and sample q values are too close or identical

Description of the changes

Take average of intensity values with duplicate Q AND solve the issue with bg interpolation when bg q and sample q values are too close or identical

Check all that apply:

  • added release notes (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items: 6776
  • Links to related issues or pull requests:

Manual test for the reviewer

Check list for the reviewer

  • release notes updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.87%. Comparing base (24f2ab8) to head (4207f12).
Report is 14 commits behind head on next.

Files Patch % Lines
src/usansred/reduce.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #13      +/-   ##
==========================================
+ Coverage   56.99%   58.87%   +1.88%     
==========================================
  Files           5        5              
  Lines         765      800      +35     
==========================================
+ Hits          436      471      +35     
  Misses        329      329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@yrshang yrshang merged commit 41009bb into next Aug 15, 2024
3 checks passed
@yrshang yrshang deleted the duplicate-q-rys branch August 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants