Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finddata conda package as dependency #14

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Add finddata conda package as dependency #14

merged 3 commits into from
Aug 12, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 12, 2024

Description of the changes

use the new finddata conda package 0.10

Check all that apply:

  • added release notes
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items: 6631

Check list for the reviewer

  • release notes updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr self-assigned this Aug 12, 2024
@jmborr jmborr merged commit 24f2ab8 into next Aug 12, 2024
1 check passed
@jmborr jmborr deleted the finddata_conda branch August 12, 2024 19:31
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.99%. Comparing base (f24bf10) to head (e675578).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #14   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files           5        5           
  Lines         765      765           
=======================================
  Hits          436      436           
  Misses        329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant