Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, change function selector synthetic sighash #167

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

sifislag
Copy link
Collaborator

@sifislag sifislag commented Nov 25, 2024

Minor refactor in decompiler logic, introduce a new constant FUNCTION_SELECTOR_SIGHASH with value 0xff5e1ec7.
Was needed as constant FALLBACK_FUNCTION_SIGHASH was used both for the fallback function and function selector.
Doesn't affect our results.

Copy link

github-actions bot commented Nov 25, 2024

Test Results (Souffle 2.3)

57 tests  ±0   57 ✅ ±0   43m 54s ⏱️ +34s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5cd05e1. ± Comparison against base commit 2b44314.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 25, 2024

Test Results (Souffle 2.4)

57 tests  ±0   57 ✅ ±0   44m 9s ⏱️ +13s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5cd05e1. ± Comparison against base commit 2b44314.

♻️ This comment has been updated with latest results.

@sifislag sifislag changed the title Refactor fallback selector Refactor, change function selector synthetic sighash Nov 25, 2024
@sifislag sifislag merged commit ff365c3 into master Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant