[Disable Gifs] Minor refinements#1971
Closed
marcustyphoon wants to merge 9 commits intonew-xkit:masterfrom
Closed
Conversation
i think this doesn't belong here. if Shorten Posts' UI is z-indexed to 79 for no reason, that's a problem with Shorten Posts, not Disable GIFs. and, if Shorten Posts needs to z-index the notes container as well, it should do that itself instead of relying on Disable GIFs to do it. |
AprilSylph
requested changes
Aug 28, 2020
Co-authored-by: April Sylph <april@sylph.tech>
honestly this is just for the aesthetic of the PR page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by Purple Hinagiku on the Discord where disabled gifs were overlaid on top of the notes window of a previous post. This is because they shared a z-index value of 1; this simply adjusts
baseContainerto380, which... hopefully doesn't break anything. (The header's at 100, so at least thats not an issue.)Also fixed a broken
destroyandadded backremoved the "hide posts with gifs" function since I was here anyway.