Update SimpleSerial2.py #546
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix `print(target)` functionality by taking out not implemented components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
last_readlast_writecomponents are not implemented for SimpleSerialv2 and prevent printing the state of a simpleserial2 target. (As one does during debugging with both the scope and target.)Re-adding the storage of the last received and sent data is a bit more difficult now with the addition of
simpleserial_read_witherrorsas it has many control flow paths. As such taking it out is the easiest way to make the code work again.This is mostly just a small functionality fix to make expected functionality work again but feature parity between simpleserial and simpleserial2 is to be achieved later.
Also fixed missing import/namespace for used functions in the functions