Skip to content

Update CFN Template of AWS unified Firehose to integrate with Metrics Forwarder lambda #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 5, 2025

Conversation

hrai-nr
Copy link
Contributor

@hrai-nr hrai-nr commented May 6, 2025

This code changes update CFN Template of AWS unified Firehose to integrate with Metrics Forwarder lambda.
Here is the approach:

  1. Store firehose instrumentation version in the template using Mappings.
  2. At the time of release of template to S3 bucket, get latest value of instrumentation version from version.yaml and change the mapping defined in step 1.
  3. At the time of calling metrics forwarder template, use this mapping to create the required JSON.

Testing :

  1. Testing that the JSON passed to second stack is correct,
Screenshot 2025-05-06 at 10 33 21 AM 2. To test the release workflow, that the mapping is getting replaced dynamically, used cat statements to print the entire content of templates, and checked before and after by created a dummy workflow. The workflow was triggered by raising the PR and changes were tested.

@hrai-nr hrai-nr changed the base branch from develop to main May 6, 2025 06:31
@hrai-nr hrai-nr changed the base branch from main to develop May 6, 2025 06:32
@hrai-nr hrai-nr deleted the branch develop May 6, 2025 07:01
@hrai-nr hrai-nr closed this May 6, 2025
@hrai-nr hrai-nr reopened this May 6, 2025
@hrai-nr hrai-nr changed the title Nr 404106 Update CFN Template of AWS unified Firehose to integrate with Metrics Forwarder lambda May 6, 2025
@maya-jha maya-jha self-requested a review May 6, 2025 07:51
Copy link

@maya-jha maya-jha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this tested?

@hrai-nr
Copy link
Contributor Author

hrai-nr commented May 6, 2025

How was this tested?

I have added the testing method and result in PR description

maya-jha
maya-jha previously approved these changes May 6, 2025
@hrai-nr hrai-nr merged commit c931da5 into develop Jun 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants