-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Ruby 10.x Migration Guide #22296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Ruby 10.x Migration Guide #22296
Conversation
|
Hi @hannahramadan 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Please ensure the propsed changes look good by building it first in your local environment. Refer to this contribution guide to get the site up and running in your local. If you really require a preview url, reach out to one of the writers and they will generate one for you. |
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Show resolved
Hide resolved
| Cross Application Tracing (CAT) has been removed in favor of [Distributed Tracing](https://docs.newrelic.com/docs/distributed-tracing/concepts/introduction-distributed-tracing/). The configuration option `cross_application_tracer.enabled` has been removed along with the following public API methods: | ||
|
|
||
| * `NewRelic::Agent::External.process_request_metadata` | ||
| * `NewRelic::Agent::External.get_response_metadata` | ||
| * `NewRelic::Agent::Transaction::ExternalRequestSegment#process_response_metadata` | ||
| * `NewRelic::Agent::Transaction::ExternalRequestSegment#get_request_metadata` | ||
| * `NewRelic::Agent::Transaction::ExternalRequestSegment#read_response_headers` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to list all of these, but I think we should also have something about what configuration looks like if you want to turn on DT or keep it off. I know we have it documented elsewhere, but it may be worth it to repeat here. Copy/pasteable code snippets are nice in these kinds of guides.
Also, if we have any related DT APIs that can be used instead of these CAT APIs, I'd like to call them out here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/apm/agents/ruby-agent/getting-started/migration-10x-guide.mdx
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle <[email protected]>
Updated ActiveJob metrics and segments format in documentation to reflect changes in reporting.
Clarified the explanation of Cross Application Tracing removal and its replacement with Distributed Tracing.
| ``` | ||
|
|
||
| New format | ||
| ```ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merge: confirm the segment update looks like this
Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
links to related docs, screenshots, etc.