-
Notifications
You must be signed in to change notification settings - Fork 311
NR-347971 | OpenLineage event consumer writer #1959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NR-347971 | OpenLineage event consumer writer #1959
Conversation
NR-347971 | Added conditions
NR-347871 | Remove redundant line
…-nr/entity-definitions into NR-347971-add-condition
NR-347971 Add condition and tests
NR-347971 | Added filter condition on unique attribute
Nr 347971 | Fix test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly concerned about the updatedAt as part of the identifier.
And that we are saying these are entities without TTL but using synthesis.
attributes: | ||
- dataset.namespace | ||
- dataset.name | ||
- updatedAt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why updatedAt?
Wouldn't this create a new entity every time the field is updated? is that desired?
Can we talk about how many entities are we expecting here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of events received with updatedAt field are quite low ~10 per month per account.
This event is generated when schema of dataset changes and such events occur rarely but they are very important.
We want to track the changes as separate entity.
entityTagName: olin.dataset.updatedAt | ||
multiValue: false | ||
configuration: | ||
entityExpirationTime: MANUAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entities that use synthesis can't be manual they must have a TTL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our use case we want to store the history of changes to dataset schema for very long period 12+ months.
Also the number of entities generated are quite low ~10 per month per account.
So we want to handle the delete logic manually in our codebase.
marked as internal review see https://newrelic.slack.com/archives/C07ELLRFDG9/p1741961591913679?thread_ts=1741942875.625519&cid=C07ELLRFDG9 |
NR-347971 | Update expiry ttl
Relevant information
Added domain and entities for Data Pipeline Observability product
Checklist
I've read the guidelines and understand the acceptance criteria.
The value of the attribute marked as identifier will be unique and valid.
I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.