Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of APM agent via environment variables #1947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darkleaf
Copy link

@darkleaf darkleaf commented Nov 6, 2024

No description provided.

@darkleaf darkleaf requested a review from a team November 6, 2024 08:35
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@KGOH KGOH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkleaf
Copy link
Author

Hi @alvarocabanas, @DavSanchez, @davidgit, @gsanchezgavier, @alvarocabanas.

I hope you're all doing well! It has been a few weeks since I submitted this PR, and I wanted to kindly follow up to see if there's any feedback or additional changes needed from my side.

If there are any concerns or specific reasons why this hasn’t been merged yet, I’d appreciate it if you could share them so I can address them promptly. Alternatively, if the timing isn’t ideal for review right now, I’d be happy to adjust expectations.

Thanks in advance for your time and support! Looking forward to your response.

@DavSanchez
Copy link
Contributor

Hello @darkleaf ,

Thank you for your contribution, and sorry for the delay! We will be reviewing this and sharing feedback, will take some time for testing.

Best regards,
David

@DavSanchez DavSanchez self-requested a review November 27, 2024 23:23
@DavSanchez DavSanchez self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants