Nr 337529 infra agent flaky test #1957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout was increased to
500 * time.Millisecond
allow enough time to set things up correctly.The flakiness was due to the test expecting this specific error
http2.ErrUnexepectedResponseCode.Error()
but instead might get"context deadline exceeded"
as the error sometimes.By increasing timeout, there is more time for the right response to be received from the server.
Another way would be to expect that the server might timeout sometimes and check for
"context deadline exceeded."
.