Skip to content

Nr 337529 infra agent flaky test #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

rahulreddy15
Copy link
Contributor

@rahulreddy15 rahulreddy15 commented Nov 25, 2024

Timeout was increased to 500 * time.Millisecond allow enough time to set things up correctly.
The flakiness was due to the test expecting this specific error http2.ErrUnexepectedResponseCode.Error() but instead might get "context deadline exceeded" as the error sometimes.
By increasing timeout, there is more time for the right response to be received from the server.

Another way would be to expect that the server might timeout sometimes and check for "context deadline exceeded." .

@rahulreddy15 rahulreddy15 requested a review from a team as a code owner November 25, 2024 09:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12007040298

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 57.366%

Files with Coverage Reduction New Missed Lines %
internal/httpapi/httpapi.go 1 74.82%
Totals Coverage Status
Change from base Build 11888184229: 0.02%
Covered Lines: 15370
Relevant Lines: 26793

💛 - Coveralls

@rahulreddy15 rahulreddy15 merged commit 99782f7 into master Nov 26, 2024
25 checks passed
@rahulreddy15 rahulreddy15 deleted the NR-337529-infra-agent-flaky-test branch November 26, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants