Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): remove logging of api-key header for debug logs #1978

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix(security): remove logging of api-key header for debug logs #1978

merged 1 commit into from
Dec 27, 2024

Conversation

rajrohanyadav
Copy link
Contributor

Description

  • Remove APIKey log
  • Fix context leak, where context was not cancelled when function returned earlier
  • Replace io/ioutil import (which was deprecated in go1.16) with io

@rajrohanyadav rajrohanyadav requested a review from a team as a code owner December 27, 2024 05:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12512088278

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.306%
Files with Coverage Reduction New Missed Lines %
internal/agent/event_sender_vortex.go 1 73.78%
internal/integrations/v4/testhelp/testemit/testemit.go 2 90.63%
pkg/helpers/recover/recover.go 6 0.0%
Totals Coverage Status
Change from base Build 12416780002: -0.02%
Covered Lines: 15354
Relevant Lines: 26793
💛 - Coveralls

rubenruizdegauna
rubenruizdegauna approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@rajrohanyadav rajrohanyadav changed the title fix(security): remove logging of sensitive API key information fix(security): remove logging of api-key header for debug logs Dec 27, 2024
@rajrohanyadav rajrohanyadav merged commit 884a878 into master Dec 27, 2024
24 checks passed
@rajrohanyadav rajrohanyadav deleted the NR-353764-remove-api-key-log branch December 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajrohanyadav @coveralls @rubenruizdegauna