-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goreleaser conflict fips #1987
Merged
Merged
Goreleaser conflict fips #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fips and non fips installed at the same time
alvarocabanas
force-pushed
the
NR_355984_goreleaser_conflict_fips
branch
from
January 9, 2025 11:03
55b393c
to
289bbc2
Compare
rajrohanyadav
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding it, it's a good catch :)
Pull Request Test Coverage Report for Build 12688534500Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12688611703Details
💛 - Coveralls |
alvarocabanas
added a commit
that referenced
this pull request
Jan 13, 2025
… fips and non fips installed at the same time (#1987)
alvarocabanas
added a commit
that referenced
this pull request
Jan 13, 2025
* feat(fips): add fips integrations when building fips infra-agent (#1969) * Nr 351326 linux prerelease fips (#1976) * Create new FIPS packages on prerelease for linux * Add FIPS molecule tests. (#1981) * Create new docker FIPS images (#1982) * feat(fips): update tests to run for fips packages (#1980) * update harvest tests to run for fips packages * chore: update action versions * update packaging tests * assume role for 2 hours as tests can take longer than 1 hour * Add conflicts to the newrelic-infra packages to not allow having both fips and non fips installed at the same time (#1987) * Add fips canaries (#1988) * Add fips canaries * Condition Fips canary previous to have a second release --------- Co-authored-by: Rohan Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conflict metadata between newrelic-infra and newrelic-infra-fips and set the right exec path for molecule fips tests.