Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goreleaser conflict fips #1987

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

alvarocabanas
Copy link
Contributor

Add conflict metadata between newrelic-infra and newrelic-infra-fips and set the right exec path for molecule fips tests.

@alvarocabanas alvarocabanas requested a review from a team as a code owner January 9, 2025 11:01
@alvarocabanas alvarocabanas changed the base branch from master to feat/fips January 9, 2025 11:01
… fips and non fips installed at the same time
@alvarocabanas alvarocabanas force-pushed the NR_355984_goreleaser_conflict_fips branch from 55b393c to 289bbc2 Compare January 9, 2025 11:03
Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for adding it, it's a good catch :)

@alvarocabanas alvarocabanas merged commit 800e0ab into feat/fips Jan 9, 2025
22 checks passed
@alvarocabanas alvarocabanas deleted the NR_355984_goreleaser_conflict_fips branch January 9, 2025 11:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12688534500

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 57.321%

Files with Coverage Reduction New Missed Lines %
pkg/backend/telemetryapi/harvester.go 2 87.62%
Totals Coverage Status
Change from base Build 12686232650: 0.0%
Covered Lines: 15358
Relevant Lines: 26793

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12688611703

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 57.325%

Files with Coverage Reduction New Missed Lines %
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 12686232650: 0.004%
Covered Lines: 15359
Relevant Lines: 26793

💛 - Coveralls

alvarocabanas added a commit that referenced this pull request Jan 13, 2025
… fips and non fips installed at the same time (#1987)
alvarocabanas added a commit that referenced this pull request Jan 13, 2025
* feat(fips): add fips integrations when building fips infra-agent (#1969)

* Nr 351326 linux prerelease fips (#1976)

* Create new FIPS packages on prerelease for linux
* Add FIPS molecule tests. (#1981)

* Create new docker FIPS images (#1982)

* feat(fips): update tests to run for fips packages (#1980)

* update harvest tests to run for fips packages
* chore: update action versions
* update packaging tests
* assume role for 2 hours as tests can take longer than 1 hour

* Add conflicts to the newrelic-infra packages to not allow having both fips and non fips installed at the same time (#1987)

* Add fips canaries (#1988)

* Add fips canaries
* Condition Fips canary previous to have a second release

---------

Co-authored-by: Rohan Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants