feat(php): annotationless install (#122)

* feat(php): annotationless install * Add helm repo update to CI --------- Co-authored-by: Tim Pansino <[email protected]>
newrelic · Nov 7, 2024 · 23d2027 · 23d2027
1 parent 895e023
commit 23d2027
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -73,6 +73,7 @@ jobs:
       - name: Deploy New Relic k8s-agents-operator to minikube
         run: |
           helm repo add k8s-agents-operator https://newrelic.github.io/k8s-agents-operator
+          helm repo update
           helm upgrade --install k8s-agents-operator k8s-agents-operator/k8s-agents-operator \
             --namespace=default \
             --set=licenseKey=${{ secrets.NEW_RELIC_LICENSE_KEY }} \

diff --git a/tests/php/chart/templates/deployment.yaml b/tests/php/chart/templates/deployment.yaml
@@ -13,8 +13,6 @@ spec:
       labels:
         app: test-app-php
         app.newrelic.instrumentation: newrelic-php-agent
-      annotations:
-        instrumentation.newrelic.com/php-version: "{{ .Values.phpVersion }}"
     spec:
       containers:
         - name: test-app-php

diff --git a/tests/php/chart/templates/instrumentation.yaml b/tests/php/chart/templates/instrumentation.yaml
@@ -10,5 +10,5 @@ spec:
         operator: "In"
         values: ["newrelic-php-agent"]
   agent:
-    language: php
+    language: "php-{{ .Values.phpVersion }}"
     image: e2e/newrelic-php-init:e2e