-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to New Operator API Version #145
Conversation
1b607c1
to
19e1a60
Compare
14848d4
to
9238d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this fix https://github.com/newrelic/newrelic-agent-init-container/actions/runs/12938075032/job/36087424632 and allow our latest (12.11.2) image to be published?
@jsumners-nr When we get this PR working, yes |
Cool. We have a patch release of Node.js that needs to go out to solve a customer issue and they are blocked on installing it because they rely on these images. |
a9f5a66
to
7422497
Compare
eb90318
to
765b6b0
Compare
765b6b0
to
eacefb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for chasing this down!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimPansino, thanks for putting this together! I have a few comments/questions about the changes.
Also, I'm not really familiar with Makefiles, so I apologize if some of these comments are really basic.
This was my first time running the Makefile on my machine. The script wouldn't complete if I just ran the all
command. When I followed the steps in the README to run each step individually, it worked. After that point, if I ran all
, it would work.
That might be a problem that predates this PR, but wanted to call it out JIC.
Other people have had that problem too, I think it's just a timing thing. The minikube cluster or the operator might need more time to settle. Might adjust that later. |
I like the Makefile, that is a convention that is popular in the Kubernetes ecosystem and I am sure customers will like it. Since the Go team does not have an agent operator integration yet, don't let my comments hold you guys back. I spent a lot of professional time managing resources in Kubernetes environments, so if you wanted an extra set of eyes I'm happy to help out from time to time. |
v1beta1
API Version for the new operator changes.controllerManager.manager.image.version
instead ofcontrollerManager.manager.image.tag