Skip to content

feat: Mfe refactor #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: Mfe refactor #1495

wants to merge 12 commits into from

Conversation

metal-messiah
Copy link
Member

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

Related Issue(s)

Testing

Copy link

github-actions bot commented Jun 7, 2025

Supportability Metric Usage Changes:

File Content
src/features/utils/event-buffer.js this.featureAgg?.reportSupportabilityMetric(smTag(this.featureAgg.featureName), addSize) // bytes dropped for this feature will aggregate with this metric tag
src/features/utils/event-buffer.js this.featureAgg?.reportSupportabilityMetric(smTag(Combined), addSize) // all bytes dropped across all features will aggregate with this metric tag

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

Copy link

github-actions bot commented Jun 7, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.55 kB / 9.65 kB (gzip) 25.53 kB / 9.64 kB (gzip) -0.08% / -0.13% (gzip)
lite async-chunk 52.6 kB / 17.45 kB (gzip) 50.04 kB / 16.68 kB (gzip) -4.86% / -4.41% (gzip)
pro loader 53.52 kB / 18.8 kB (gzip) 52.77 kB / 18.55 kB (gzip) -1.39% / -1.3% (gzip)
pro async-chunk 92 kB / 28.53 kB (gzip) 89.32 kB / 27.79 kB (gzip) -2.91% / -2.6% (gzip)
spa loader 62.28 kB / 21.52 kB (gzip) 61.53 kB / 21.25 kB (gzip) -1.19% / -1.22% (gzip)
spa async-chunk 116.7 kB / 35.51 kB (gzip) 113.95 kB / 34.76 kB (gzip) -2.36% / -2.11% (gzip)

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 80.18868% with 21 lines in your changes missing coverage. Please review.

Project coverage is 87.81%. Comparing base (def89c4) to head (0cc29eb).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/features/jserrors/aggregate/index.js 0.00% 7 Missing and 6 partials ⚠️
src/features/generic_events/aggregate/index.js 66.66% 3 Missing ⚠️
src/common/harvest/harvester.js 86.66% 1 Missing and 1 partial ⚠️
src/features/session_replay/aggregate/index.js 77.77% 2 Missing ⚠️
src/features/page_view_event/aggregate/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1495      +/-   ##
==========================================
+ Coverage   87.64%   87.81%   +0.17%     
==========================================
  Files         197      197              
  Lines        7778     7641     -137     
  Branches     1565     1532      -33     
==========================================
- Hits         6817     6710     -107     
+ Misses        827      807      -20     
+ Partials      134      124      -10     
Flag Coverage Δ
unit-tests 79.39% <80.18%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Jun 7, 2025

Static Badge

Last ran on June 10, 2025 19:10:15 CDT
Checking merge of (b40e76a) into main (82b9f78)

@metal-messiah
Copy link
Member Author

Needs confirmation from DEM platform and PM on the required payload items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant