fix uncontrolled data used in path expression loader-transform #1519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newrelic-browser-agent/tools/testing-server/plugins/agent-injector/loader-transform.js
Line 18 in 39c9fb5
newrelic-browser-agent/tools/testing-server/plugins/agent-injector/loader-transform.js
Lines 26 to 30 in 39c9fb5
Accessing files using paths constructed from user-controlled data can allow an attacker to access unexpected resources. This can result in sensitive information being revealed or deleted, or an attacker being able to influence behavior by modifying unexpected files.
Fix the
loader-transform:feat
need to validate and sanitize theloader
value before using it to construct the file path. Since theloader
value is used to determine a specific file name, we can use an allowlist approach to restrict it to a predefined set of valid loader names. This ensures that only expected and safe file paths are constructed.['default', 'custom']
).loader
value against this allowlist in thegetLoaderFilePath
function.loader
value is invalid, throw an error or use a default value.References