Skip to content

chore: Jobs should run only if find-pull-request was successful #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ptang-nr
Copy link
Contributor

@ptang-nr ptang-nr commented Jul 1, 2025

Patch false failures in PR checks

Overview

Recently, the GHA behavior for PR checks appears to have changed and would display a failure status even if everything passed. It looks like it's reporting a failure status due to subsequent jobs trying to evaluate fromJSON on an empty input. In the past and in theory, these subsequent jobs shouldn't have fired at all since the job it depends on was skipped.

So in this PR, attempt to fix the false failure status by requiring subsequent jobs to also check for a success status from the find-pull-request job.

Example PR check with the false failure: https://github.com/newrelic/newrelic-browser-agent/actions/runs/16011444259
Screenshot 2025-07-01 at 4 47 56 PM
Screenshot 2025-07-01 at 4 48 11 PM

Related Issue(s)

Testing

Copy link

github-actions bot commented Jul 1, 2025

Supportability Metric Usage Changes:

No matching changes found

Supportability Metrics .md File Changes:

supportability_metrics.md was changed? false

New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR.

Copy link

github-actions bot commented Jul 1, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 25.55 kB / 9.65 kB (gzip) 25.55 kB / 9.65 kB (gzip) 0% / 0% (gzip)
lite async-chunk 53.01 kB / 17.57 kB (gzip) 53.01 kB / 17.57 kB (gzip) 0% / 0% (gzip)
pro loader 53.72 kB / 18.89 kB (gzip) 53.72 kB / 18.89 kB (gzip) 0% / 0% (gzip)
pro async-chunk 92.21 kB / 28.56 kB (gzip) 92.21 kB / 28.56 kB (gzip) 0% / 0% (gzip)
spa loader 62.48 kB / 21.6 kB (gzip) 62.48 kB / 21.6 kB (gzip) 0% / 0% (gzip)
spa async-chunk 116.93 kB / 35.56 kB (gzip) 116.93 kB / 35.56 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (e3ca824) to head (5bd9b28).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         197      197           
  Lines        7795     7795           
  Branches     1571     1571           
=======================================
  Hits         6846     6846           
  Misses        818      818           
  Partials      131      131           
Flag Coverage Δ
unit-tests 79.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant