chore: Jobs should run only if find-pull-request was successful #1523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch false failures in PR checks
Overview
Recently, the GHA behavior for PR checks appears to have changed and would display a failure status even if everything passed. It looks like it's reporting a failure status due to subsequent jobs trying to evaluate
fromJSON
on an empty input. In the past and in theory, these subsequent jobs shouldn't have fired at all since the job it depends on was skipped.So in this PR, attempt to fix the false failure status by requiring subsequent jobs to also check for a success status from the
find-pull-request
job.Example PR check with the false failure: https://github.com/newrelic/newrelic-browser-agent/actions/runs/16011444259


Related Issue(s)
Testing