Skip to content

feat: Add support for Azure Service Bus #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 27, 2025

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented May 19, 2025

Description

  • Adds support for Azure Service Bus, including "processor mode", as a new message broker.
  • Expands available message broker actions to match OTel with on new kind, "Peek".
  • Adds transaction GUID to Transaction.Ignore() and TransactionGarbage collected log messages.
  • IntegrationTests: SetLogLevel now returns a NewRelicConfigModifier object.
  • ExecutionTimer class moved to its own file.
  • Includes UnboundedTests for manual and processor modes as well as W3C.
  • UnitTests: Updates SegmentTests to check for all the message broker actions and any "bad" actions.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito marked this pull request as ready for review May 21, 2025 19:43
@jaffinito jaffinito requested a review from a team as a code owner May 21, 2025 19:43
@jaffinito jaffinito changed the title Feature/azure service bus instrumentation feat: Add support for Azure Service Bus May 21, 2025
tippmar-nr
tippmar-nr previously approved these changes May 27, 2025
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 🚀

…viceBus/AzureServiceBusReceiveWrapper.cs

Co-authored-by: Marty T <[email protected]>
@jaffinito
Copy link
Member Author

Docs change newrelic/docs-website#20774

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (46c4cd0) to head (111da17).

Files with missing lines Patch % Lines
...elic/Agent/Core/AgentHealth/AgentHealthReporter.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   82.31%   82.35%   +0.03%     
==========================================
  Files         479      479              
  Lines       30721    30728       +7     
  Branches     3439     3439              
==========================================
+ Hits        25289    25305      +16     
+ Misses       4629     4622       -7     
+ Partials      803      801       -2     
Flag Coverage Δ
Agent 83.41% <90.00%> (+0.03%) ⬆️
Profiler 72.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/Agent/NewRelic/Agent/Core/Metrics/MetricNames.cs 92.57% <ø> (ø)
...nt/NewRelic/Agent/Core/Transactions/Transaction.cs 81.49% <100.00%> (+0.78%) ⬆️
...ic/Agent/Core/Transactions/TransactionFinalizer.cs 98.55% <100.00%> (ø)
...ic.Agent.Extensions/Providers/Wrapper/Constants.cs 91.42% <ø> (ø)
...elic/Agent/Core/AgentHealth/AgentHealthReporter.cs 89.30% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaffinito jaffinito merged commit 6a075cc into main May 27, 2025
100 checks passed
@jaffinito jaffinito deleted the feature/azure-service-bus-instrumentation branch May 27, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants