Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): fix memleak in Laravel Queue instrumentation #1014

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

zsistla
Copy link
Contributor

@zsistla zsistla commented Feb 5, 2025

Free strings that were strdup-ed but not being freed.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Feb 5, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 72/72 passing

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (94a41f5) to head (acf90cb).

Files with missing lines Patch % Lines
agent/fw_laravel_queue.c 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1014      +/-   ##
==========================================
- Coverage   78.02%   78.00%   -0.02%     
==========================================
  Files         197      197              
  Lines       27418    27424       +6     
==========================================
  Hits        21392    21392              
- Misses       6026     6032       +6     
Flag Coverage Δ
agent-for-php-7.2 78.15% <0.00%> (-0.01%) ⬇️
agent-for-php-7.3 78.17% <0.00%> (-0.01%) ⬇️
agent-for-php-7.4 77.88% <0.00%> (-0.01%) ⬇️
agent-for-php-8.0 77.24% <0.00%> (-0.02%) ⬇️
agent-for-php-8.1 ?
agent-for-php-8.2 77.35% <0.00%> (-0.02%) ⬇️
agent-for-php-8.3 77.35% <0.00%> (-0.02%) ⬇️
agent-for-php-8.4 77.37% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou added this to the next-release milestone Feb 5, 2025
@lavarou lavarou changed the title fix(agent): Fix memleak by freeing strdup-ed strings. fix(agent): fix memleak in Laravel Queue instrumentation Feb 5, 2025
@zsistla zsistla merged commit b0184fd into dev Feb 5, 2025
65 checks passed
@zsistla zsistla deleted the laravel_q_mem_leak branch February 5, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants