Skip to content

feat(agent): composer api package detection on by default #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

bduranleau-nr
Copy link
Contributor

@bduranleau-nr bduranleau-nr commented Apr 21, 2025

Changes the default configuration value for composer-based package detection to true.

An additional configuration value, newrelic.vulnerability_management.composer_api.per_process_detection, has also been added to control the frequency at which composer sampling occurs. By default, this setting will be enabled, only sampling Composer API data once per php-fpm process. This improves baseline performance to make the enablement of Composer API package detection a negligible overhead impact.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 21, 2025

Test Suite Status Result
Multiverse 0/8 passing
SOAK 79/85 passing

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (ca08b5a) to head (a004604).

Files with missing lines Patch % Lines
agent/php_nrini.c 71.42% 2 Missing ⚠️
agent/php_execute.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1055   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files         199      199           
  Lines       28329    28342   +13     
=======================================
+ Hits        21891    21902   +11     
- Misses       6438     6440    +2     
Flag Coverage Δ
agent-for-php-7.2 77.47% <76.92%> (+<0.01%) ⬆️
agent-for-php-7.3 77.49% <76.92%> (+<0.01%) ⬆️
agent-for-php-7.4 77.36% <76.92%> (-0.01%) ⬇️
agent-for-php-8.0 76.56% <76.92%> (+<0.01%) ⬆️
agent-for-php-8.1 76.88% <76.92%> (+<0.01%) ⬆️
agent-for-php-8.2 76.50% <76.92%> (+<0.01%) ⬆️
agent-for-php-8.3 76.50% <76.92%> (+<0.01%) ⬆️
agent-for-php-8.4 76.52% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bduranleau-nr bduranleau-nr marked this pull request as ready for review April 21, 2025 22:01
@bduranleau-nr bduranleau-nr marked this pull request as draft April 21, 2025 22:02
@bduranleau-nr bduranleau-nr marked this pull request as ready for review May 6, 2025 17:03
@bduranleau-nr bduranleau-nr force-pushed the config/composer-on-by-default branch from 5fa88c8 to ff8ff71 Compare June 4, 2025 17:23
@bduranleau-nr bduranleau-nr force-pushed the config/composer-on-by-default branch from ff8ff71 to a004604 Compare June 5, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants