Skip to content

chore(agent): update directive (2/16) #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: remove-obsolete-php5-code
Choose a base branch
from

Conversation

hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented May 30, 2025

This PR updates the directive to be #if ZEND_MODULE_API_NO >= ZEND_7_0_X_API_NO instead of #ifdef PHP7.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 30, 2025

Test Suite Status Result
Multiverse 5/8 passing
SOAK 79/85 passing

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (ae34b4f) to head (97e1380).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           remove-obsolete-php5-code    #1070   +/-   ##
==========================================================
  Coverage                      77.27%   77.27%           
==========================================================
  Files                            199      199           
  Lines                          28327    28327           
==========================================================
  Hits                           21890    21890           
  Misses                          6437     6437           
Flag Coverage Δ
agent-for-php-7.2 77.47% <ø> (ø)
agent-for-php-7.3 77.49% <ø> (ø)
agent-for-php-7.4 77.36% <ø> (ø)
agent-for-php-8.0 76.56% <ø> (ø)
agent-for-php-8.1 76.88% <ø> (ø)
agent-for-php-8.2 76.50% <ø> (ø)
agent-for-php-8.3 76.50% <ø> (ø)
agent-for-php-8.4 76.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hahuja2 hahuja2 added this to the Removing Obsolete Code milestone Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants