-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: only call cufa callback when needed #769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## wp-performance-improvements #769 +/- ##
===============================================================
- Coverage 78.27% 78.21% -0.07%
===============================================================
Files 188 188
Lines 26269 26285 +16
===============================================================
- Hits 20563 20559 -4
- Misses 5706 5726 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
approved these changes
Nov 24, 2023
Merge remote-tracking branch 'wp-performance-improvements' into cufa_check
Co-authored-by: bduranleau-nr <[email protected]>
lavarou
changed the title
fix(agent): Optimize cufa detection
refactor: don't call cufa callback when not needed
Dec 2, 2023
lavarou
changed the title
refactor: don't call cufa callback when not needed
refactor: only call cufa callback when needed
Dec 2, 2023
bduranleau-nr
approved these changes
Dec 4, 2023
bduranleau-nr
added a commit
that referenced
this pull request
Dec 6, 2023
Improve agent's performance by only calling `call_user_function_array` callback when trying to instrument Drupal or WordPress hooks. Imported from #729. --------- Co-authored-by: Michal Nowacki <[email protected]> Co-authored-by: bduranleau-nr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve agent's performance by only calling
call_user_function_array
callback when trying to instrument Drupal or WordPress hooks. Imported from #729