Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only call cufa callback when needed #769

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

zsistla
Copy link
Contributor

@zsistla zsistla commented Nov 15, 2023

Improve agent's performance by only calling call_user_function_array callback when trying to instrument Drupal or WordPress hooks. Imported from #729

@zsistla zsistla added this to the Performance Spike milestone Nov 15, 2023
@zsistla zsistla marked this pull request as draft November 15, 2023 00:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (54ad95d) 78.27% compared to head (7451347) 78.21%.

Files Patch % Lines
agent/fw_wordpress.c 37.50% 5 Missing ⚠️
agent/fw_drupal.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           wp-performance-improvements     #769      +/-   ##
===============================================================
- Coverage                        78.27%   78.21%   -0.07%     
===============================================================
  Files                              188      188              
  Lines                            26269    26285      +16     
===============================================================
- Hits                             20563    20559       -4     
- Misses                            5706     5726      +20     
Flag Coverage Δ
agent-for-php-7.0 76.95% <35.29%> (-0.08%) ⬇️
agent-for-php-7.1 76.68% <35.29%> (-0.07%) ⬇️
agent-for-php-7.2 77.24% <35.29%> (-0.07%) ⬇️
agent-for-php-7.3 77.26% <35.29%> (-0.07%) ⬇️
agent-for-php-7.4 77.05% <52.94%> (-0.06%) ⬇️
agent-for-php-8.0 77.14% <52.94%> (-0.07%) ⬇️
agent-for-php-8.1 77.10% <52.94%> (-0.07%) ⬇️
agent-for-php-8.2 76.88% <52.94%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zsistla zsistla marked this pull request as ready for review November 16, 2023 13:33
agent/fw_drupal8.c Outdated Show resolved Hide resolved
agent/php_vm.c Outdated Show resolved Hide resolved
bduranleau-nr added a commit that referenced this pull request Dec 1, 2023
lavarou and others added 2 commits December 1, 2023 18:12
Merge remote-tracking branch 'wp-performance-improvements' into cufa_check
@lavarou lavarou changed the title fix(agent): Optimize cufa detection refactor: don't call cufa callback when not needed Dec 2, 2023
@lavarou lavarou changed the title refactor: don't call cufa callback when not needed refactor: only call cufa callback when needed Dec 2, 2023
@lavarou lavarou added the ready-for-merge PR ready for merge to upstream label Dec 2, 2023
@lavarou lavarou merged commit 6389c69 into wp-performance-improvements Dec 4, 2023
49 checks passed
@lavarou lavarou deleted the cufa_check branch December 4, 2023 22:08
@lavarou lavarou removed the ready-for-merge PR ready for merge to upstream label Dec 4, 2023
bduranleau-nr added a commit that referenced this pull request Dec 6, 2023
Improve agent's performance by only calling `call_user_function_array`
callback when trying to instrument Drupal or WordPress hooks. Imported
from #729.

---------

Co-authored-by: Michal Nowacki <[email protected]>
Co-authored-by: bduranleau-nr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants