refactor: limit wordpress instrumentation #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavarou
force-pushed
the
refactor/limit-wordpress-instrumentation
branch
from
a93622f to
e31f538
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## wp-performance-improvements #786 +/- ##
============================================================
Coverage 78.27% 78.27%
============================================================
Files 188 188
Lines 26269 26270 +1
============================================================
+ Hits 20563 20564 +1
Misses 5706 5706
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lavarou
force-pushed
the
refactor/limit-wordpress-instrumentation
branch
from
0186678 to
13c9297
Compare
lavarou
force-pushed
the
refactor/limit-wordpress-instrumentation
branch
from
13c9297 to
959ae2d
Compare
lavarou
changed the base branch from
ads/wp_add_filter
to
wp-performance-improvements
There's no need to wrap WordPress 'hook' functions when WordPress hooks are to not be instrumented. In such case instrumentation is limited to transaction naming only.
lavarou
force-pushed
the
refactor/limit-wordpress-instrumentation
branch
from
959ae2d to
1fbb0d1
Compare
ZNeumann
reviewed
Dec 5, 2023
ZNeumann
approved these changes
Dec 5, 2023
bduranleau-nr
approved these changes
Dec 5, 2023
bduranleau-nr
pushed a commit
that referenced
this pull request
Dec 6, 2023
Improve agent's performance when WordPress hook tracking is disabled with `newrelic.framework.wordpress.hooks` set to `false`. There's no need to wrap WordPress 'hook' functions when WordPress hooks are not to be instrumented. In such case, instrumentation is limited to transaction naming only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve agent's performance when WordPress hook tracking is disabled with
newrelic.framework.wordpress.hooksset tofalse. There's no need to wrap WordPress 'hook' functions when WordPress hooks are to not be instrumented. In such case, instrumentation is limited to transaction naming only.