Skip to content

Enable pyflakes #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Enable pyflakes #1354

wants to merge 20 commits into from

Conversation

TimPansino
Copy link
Contributor

Overview

  • Enable pyflakes linter in ruff.
  • Fix all pyflakes violations.
  • Correct issues found in openai, kombu, and psycopg2 instrumentation (noticed due to linter violations).

@TimPansino TimPansino requested a review from a team as a code owner April 11, 2025 21:24
Copy link

github-actions bot commented Apr 11, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.44s
✅ MARKDOWN markdownlint 7 0 0 0 1.0s
✅ MARKDOWN markdown-link-check 7 0 0 13.14s
✅ PYTHON ruff 892 0 0 0 0.61s
✅ PYTHON ruff-format 892 0 0 0 0.31s
✅ YAML prettier 13 0 0 0 0.99s
✅ YAML v8r 13 0 0 6.59s
✅ YAML yamllint 13 0 0 0.55s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (02d14d0) to head (aed70a9).

Files with missing lines Patch % Lines
newrelic/hooks/database_psycopg2.py 0.00% 2 Missing and 2 partials ⚠️
newrelic/hooks/external_botocore.py 20.00% 4 Missing ⚠️
newrelic/api/out_function.py 0.00% 1 Missing ⚠️
newrelic/core/agent_control_health.py 0.00% 1 Missing ⚠️
newrelic/hooks/database_aiomysql.py 0.00% 1 Missing ⚠️
newrelic/hooks/framework_graphql.py 0.00% 1 Missing ⚠️
newrelic/hooks/messagebroker_kombu.py 0.00% 1 Missing ⚠️
newrelic/hooks/mlmodel_langchain.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   81.07%   81.05%   -0.02%     
==========================================
  Files         204      204              
  Lines       22832    22816      -16     
  Branches     3618     3620       +2     
==========================================
- Hits        18510    18493      -17     
+ Misses       3122     3120       -2     
- Partials     1200     1203       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot removed the merge-conflicts label Apr 17, 2025
@mergify mergify bot removed the tests-failing label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants