Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ES Module loader initial implementation #1348

Merged
merged 14 commits into from
Sep 12, 2022
Merged

Add ES Module loader initial implementation #1348

merged 14 commits into from
Sep 12, 2022

Commits on Sep 8, 2022

  1. Add resolve hook for ES Modules

    @jmartin4563
    jmartin4563 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    93a386c View commit details
    Browse the repository at this point in the history

  2. Add unit tests using testdouble for dependency mocking 

    Proxyquire doesn't work in an import setting, it only works with require
    @jmartin4563
    jmartin4563 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9507b44 View commit details
    Browse the repository at this point in the history

  3. Update eslint config to support import() syntax

    @jmartin4563
    jmartin4563 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    66b1dc5 View commit details
    Browse the repository at this point in the history

  4. Update unit tests to include explict end()

    @jmartin4563
    jmartin4563 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    77e5e7c View commit details
    Browse the repository at this point in the history

  5. Make unit test suite more DRY

    @jmartin4563
    jmartin4563 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    06a70f9 View commit details
    Browse the repository at this point in the history

  6. Run eslint on our .mjs files

    @jmartin4563
    jmartin4563 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    a0b1513 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Add ESM unit test npm script and update CI to use it

    @jmartin4563
    jmartin4563 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    7f19bc5 View commit details
    Browse the repository at this point in the history

  2. Update comments and logging to keep line length down

    @jmartin4563
    jmartin4563 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    c125656 View commit details
    Browse the repository at this point in the history

  3. Update package.json files so loader file is shipped in package

    @jmartin4563
    jmartin4563 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    022bf3e View commit details
    Browse the repository at this point in the history

  4. Move eslint setting to test-only eslint config 

    I only added that parserOptions stanza to fix a parsing issue in my unit test file, but configuring it in the top-level eslintrc.js meant that I updated eslint to allow things that would have broken in node14. By configuring in the test-only eslint config, we limit the blast radius of this potential issue
    @jmartin4563
    jmartin4563 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    063ab42 View commit details
    Browse the repository at this point in the history

  5. Optimize return value to prevent GC thrashing and fix logic issue wit… 

    …h debug statements
    @jmartin4563
    jmartin4563 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    5951051 View commit details
    Browse the repository at this point in the history

  6. Update to use logging module directly so we only instantiate once

    @jmartin4563
    jmartin4563 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    ba96f68 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Switch to use agent property to assert liveliness of instrumentation

    @jmartin4563
    jmartin4563 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3c260d5 View commit details
    Browse the repository at this point in the history

  2. Added comment explaining call to nextResolve()

    @jmartin4563
    jmartin4563 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    9335a6f View commit details
    Browse the repository at this point in the history