Skip to content

feat: Added supportability metrics when instrumentation has been disabled for a package #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bizob2828
Copy link
Member

Description

This PR adds supportability metrics in the form of Supportability/Nodejs/Instrumentation/<pkg>/disabled when instrumentation for a package has been disabled. This is useful for tracking which instrumentations are not being used by customers.

Angler PR

Related Issues

Closes #3085

@bizob2828 bizob2828 force-pushed the disabled-instrumentation-metric branch from 94e9fec to a63409b Compare July 25, 2025 21:00
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.61%. Comparing base (19a9c78) to head (a63409b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3252      +/-   ##
==========================================
- Coverage   97.66%   97.61%   -0.05%     
==========================================
  Files         345      345              
  Lines       51734    51747      +13     
==========================================
- Hits        50526    50514      -12     
- Misses       1208     1233      +25     
Flag Coverage Δ
integration-tests-cjs-20.x 73.91% <84.61%> (+<0.01%) ⬆️
integration-tests-cjs-22.x 73.95% <84.61%> (+<0.01%) ⬆️
integration-tests-cjs-24.x 74.68% <84.61%> (-0.01%) ⬇️
integration-tests-esm-20.x 49.52% <ø> (ø)
integration-tests-esm-22.x 49.59% <ø> (ø)
integration-tests-esm-24.x 51.29% <ø> (ø)
unit-tests-20.x 88.30% <100.00%> (+<0.01%) ⬆️
unit-tests-22.x 88.31% <100.00%> (+<0.01%) ⬆️
unit-tests-24.x 88.32% <100.00%> (+<0.01%) ⬆️
versioned-tests-20.x 80.23% <ø> (-0.18%) ⬇️
versioned-tests-22.x 80.24% <ø> (-0.18%) ⬇️
versioned-tests-24.x 80.14% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrickard mrickard self-assigned this Jul 25, 2025
Copy link
Member

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the batch-span-streamer test shouldn't be affected by this code change, it seems as though it's just flappy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs PR Review
Development

Successfully merging this pull request may close these issues.

Create supportability metrics for when instrumentation is disabled
2 participants